Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple values custom config #121

Merged
merged 2 commits into from
Feb 27, 2019
Merged

Conversation

jchanam
Copy link
Collaborator

@jchanam jchanam commented Feb 25, 2019

Fixes #118

Changes proposed on the PR:

  • Split the customConfigs in parameter and value, so values with multiple data can be used

Julio Chana added 2 commits February 25, 2019 16:24
@jchanam jchanam requested review from slok, ese and chusAlvarez February 25, 2019 16:03
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some fixes!

P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).

service/redis/client.go Show resolved Hide resolved
service/redis/client.go Show resolved Hide resolved
service/redis/client.go Show resolved Hide resolved
@jchanam jchanam merged commit ebb70bd into master Feb 27, 2019
@jchanam jchanam deleted the fix-multiple-values-custom-config branch February 27, 2019 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants