Devops 632 add or delete exporter on update #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jchanam
commented
Dec 29, 2017
jchanam
commented
- On update, add or delete exporter if changed.
- Bump version to 0.1.3 to create new release
ese
reviewed
Dec 29, 2017
pkg/failover/client.go
Outdated
| v1.ResourceMemory: resource.MustParse("300Mi"), | ||
| }, | ||
| Requests: v1.ResourceList{ | ||
| v1.ResourceCPU: resource.MustParse("200m"), |
There was a problem hiding this comment.
Too much default requests, I think 25m cpu and 50Mi RAM is enough
ese
approved these changes
Dec 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.