Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump memory to help CVE-patched runc start containers #115

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Bump memory to help CVE-patched runc start containers #115

merged 1 commit into from
Feb 19, 2019

Conversation

arnaudmz
Copy link
Contributor

Initcontainers fail with message : message: 'OCI runtime create failed: container_linux.go:348: starting container process caused "process_linux.go:402: container init caused \"process_linux.go:367: setting cgroup config for procHooks process caused \\\"failed to write 10485760 to memory.limit_in_bytes: write /sys/fs/cgroup/memory/kubepods/burstable/pod8b46ac66-3396-11e9-8868-06008508f8fe/312653fa8dac427416a12f4d3398ced9782229867907f8179697e8858f7a401d/memory.limit_in_bytes: device or resource busy\\\"\"": unknown' reason: ContainerCannotRun

@ese
Copy link
Member

ese commented Feb 18, 2019

@arnaudmz could you explain how that value can affect to patched runc?

@arnaudmz
Copy link
Contributor Author

I ran into this issue (opencontainers/runc#1980) related to runc that seems to show that due to the copy of runc binary, their conclusion is :

We need to set higher memory limit for the container to run, and the minimum limit is larger than the runc binary size
Before 6635b4f, the minimum limit is not that high, and much lower than the runc binary size.
This is a regression to users, their existing workloads may not run without tweaking memory limit.

@ese
Copy link
Member

ese commented Feb 19, 2019

Thank you so much @arnaudmz

@ese ese merged commit abeebf0 into spotahome:master Feb 19, 2019
@arnaudmz
Copy link
Contributor Author

Thanks.

Can you tell me if latest image on quay.io contains the fix?

@jchanam
Copy link
Collaborator

jchanam commented Feb 19, 2019

@arnaudmz I'm creating a release. I'll tell you as soon as I have it.

@arnaudmz
Copy link
Contributor Author

@jchanam, great, thanks.

@jchanam
Copy link
Collaborator

jchanam commented Feb 19, 2019

@arnaudmz Version 0.5.5 is released

@malczun
Copy link

malczun commented May 7, 2019

I'm sorry I'm digging up the subject that's 3 months old, but I'm having the same problem and it only stops at about 24Mi for memory. Could I make a PR that bump this to 32Mi to have more margin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants