Add config content variables for readability. #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchanam
reviewed
Feb 15, 2019
| @@ -88,6 +88,10 @@ func generateSentinelConfigMap(rf *redisfailoverv1alpha2.RedisFailover, labels m | |||
| namespace := rf.Namespace | |||
|
|
|||
| labels = util.MergeLabels(labels, generateLabels(sentinelRoleName, rf.Name)) | |||
| sentinelConfigFileNameContent := `sentinel monitor mymaster 127.0.0.1 6379 2 | |||
There was a problem hiding this comment.
I'd rename this to sentinelConfigFileContent
| @@ -110,6 +111,10 @@ func generateRedisConfigMap(rf *redisfailoverv1alpha2.RedisFailover, labels map[ | |||
| namespace := rf.Namespace | |||
|
|
|||
| labels = util.MergeLabels(labels, generateLabels(redisRoleName, rf.Name)) | |||
| redisConfigFileNameContent := `slaveof 127.0.0.1 6379 | |||
There was a problem hiding this comment.
I'd rename this to redisConfigFileContent
|
Signed-off-by: Morales Quispe, Marcela <[email protected]>
marcemq
force-pushed
the
content-variables
branch
from
32d9d8f to
56374d1
Compare
jchanam
approved these changes
Feb 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed on the PR:
sentinelConfigFileNameContent,redisConfigFileNameContentandshutdownContentto hold the proper content of eachCongifMapdata entry.Signed-off-by: Morales Quispe, Marcela [email protected]