Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use our created ServiceAccount #103

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Use our created ServiceAccount #103

merged 2 commits into from
Oct 30, 2018

Conversation

Paic
Copy link
Contributor

@Paic Paic commented Oct 30, 2018

If not precised, the operator will use the namespace default ServiceAccount, which does not have any permissions for CRD etc…

@Paic
Use our created ServiceAccount
5bb0d3a 
If not precised, the operator will use the namespace default ServiceAccount, which does not have any permissions for CRD etc…
@Paic Paic requested review from ese, jchanam and slok as code owners October 30, 2018 11:54
jchanam
jchanam approved these changes Oct 30, 2018
View reviewed changes
Copy link
Collaborator

@jchanam jchanam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@jchanam jchanam merged commit 4a7661c into spotahome:master Oct 30, 2018
@Paic Paic deleted the examples-fix branch October 30, 2018 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchanam jchanam jchanam approved these changes

@ese ese Awaiting requested review from ese

@slok slok Awaiting requested review from slok

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Paic @jchanam