Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to use Prometheus annotation #37

Closed
Kyrremann opened this issue Apr 3, 2018 · 1 comment
Closed

How to use Prometheus annotation #37

Kyrremann opened this issue Apr 3, 2018 · 1 comment

Comments

@Kyrremann
Copy link
Contributor

I'm trying to communicate with the redis-exporter in each rfr- pod, but as the normal Prometheus annotations are missing, and I only have one service to communicate with all three of my pods, I don't get the data I want.

Have you thought about adding the annotation to each redis-exporter container? So that we can scrape each of them, instead of a service point?

The annotation I'm thinking about is:

  Annotations:  prometheus.io/path=/metrics
                prometheus.io/port=http
                prometheus.io/scrape=true

Also, do we really need the service point for Prometheus scraping? Isn't it better to scrape each pod with an redis-exporter, so we get more precise data about the load?

I'm writing the code needed for it for us. Can create a PR when I'm done.

jchanam added a commit that referenced this issue Apr 6, 2018
@jchanam
Copy link
Collaborator

jchanam commented Apr 6, 2018

Thanks for the PR @Kyrremann

The release is created and ready to use: https://github.com/spotahome/redis-operator/releases/tag/0.2.2

@jchanam jchanam closed this as completed Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants