Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Delete event concept from Kooper #90

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Conversation

slok
Copy link
Collaborator

@slok slok commented Apr 7, 2020

This PR removes the concept of delete event from Kooper.

Deletion event reception can't be guaranteed, this is because The controller can be down/restarting or have a networking issue and the deletion event will never reach the controller. This means that the delete event is not reliable.

We prefer not having an event that can work sometimes, we don't want the user to have false assumptions. Instead finalizers usage is encouraged.

Signed-off-by: Xabier Larrakoetxea <[email protected]>
@slok slok requested a review from ese as a code owner April 7, 2020 08:04
@slok slok merged commit dc1d470 into spotahome:refactor Apr 8, 2020
@slok slok deleted the slok/gc branch April 8, 2020 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants