Update lrc.py for updated function in python-syncedlyrics

[jerz4lunch]

See syncedlyrics commit: here

Change function call from is_lrc_valid to has_translation

I changed the import of is_lrc_valid to has_translation and changed function call in the same way.

Related Issue

It should solve the problem where the program wouldn't start since the function name was changed in required package python-syncedlyrics

How Has This Been Tested?

I tested this, but poetry brings in older version of syncedlyrics than the one in the AUR which doesn't have relevant change, so I am not sure it this will actually work. I am not sure how to test it with the correct version of the dependency. If someone could guide me on how to use the correct version with poetry, I would greatly appreciate it. It looks like it should work given the commit in the project.

Screenshots (if appropriate)

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the CONTRIBUTING document
• I have read the CORE VALUES document
• I have added tests to cover my changes
• All new and existing tests passed

This is my first time creating a pull request, so any guidance is appreciated.

[Cornelius-Figgle]

If someone could guide me on how to use the correct version with poetry, I would greatly appreciate it.

Not sure if this is what you mean, but you can change the version set in pyproject.toml. See here for more details. I believe that as syncedlyrics has had a major version change, poetry will not automatically update it. In your case, changing the version of syncedlyrics to ^1.0.0 should be enough. You will then have to regenerate the lockfile and reinstall the environment.

The commands to do this are:

poetry add syncedlyrics@^1.0.0  # change version
poetry update                   # regenerate lockfile and reinstall

[aminvakil]

If someone could guide me on how to use the correct version with poetry, I would greatly appreciate it.

Not sure if this is what you mean, but you can change the version set in pyproject.toml. See here for more details. I believe that as syncedlyrics has had a major version change, poetry will not automatically update it. In your case, changing the version of syncedlyrics to ^1.0.0 should be enough. You will then have to regenerate the lockfile and reinstall the environment.

The commands to do this are:

poetry add syncedlyrics@^1.0.0  # change version
poetry update                   # regenerate lockfile and reinstall

This is just a temporary workaround and not a solution for this.

[Cornelius-Figgle]

How come?

[aminvakil]

How come?

I'm co-maintainer of https://aur.archlinux.org/packages/spotdl on AUR, and as python-syncedlyrics package has been upgraded to 1.0.0, you cannot depend on 0.10.0 of syncedlyrics anymore in my environment.

I don't mean to be demanding or anything by saying this, but it's not like everyone uses poetry to use this package.

[Cornelius-Figgle]

you cannot depend on 0.10.0 of syncedlyrics anymore

That is what @jerz4lunch was trying to fix no? Perhaps I misunderstand here, but my understanding was they had updated the SpotDL code to use the new version of syncedlyrics, but didn't no how to update the poetry details.

it's not like everyone uses poetry to use this package

Of course, but poetry is what is used to develop it, and some people do so all installation methods need to be updated to support 1.0.0

[aminvakil]

Oops! I thought what you meant was to stick to older version, sorry for inconvenience.

[Cornelius-Figgle]

No worries :)

[jerz4lunch]

Did what @Cornelius-Figgle suggested and now another function has to be updated. I would have looked into this before, but didn't know the proper steps to check. I'm closing this until I get everything working in my environment, and will submit another PR when that happens.

[jerz4lunch]

It seems to run just fine now with this latest update. The program runs. However, I am not sure how to test the lyrics functionality to make sure I didn't break something else. If I could get some help on that, I would greatly appreciate it!

[Cornelius-Figgle]

I am not sure how to test the lyrics functionality

Install pytest and run the tests I think.

[jerz4lunch]

I am not sure how to test the lyrics functionality

Install pytest and run the tests I think.

I got some errors. However, the test failures are not related to the code fix I made. So now what?

[pekkarr]

I backported this pr into the AUR package, and spotdl seems to work with it.

cc @aminvakil

[aminvakil]

I've also tested and it works fine:
https://github.com/aminvakil/aur/actions/runs/9726681332/job/26845485832

[Cornelius-Figgle]

the test failures are not related to the code fix I made

I think you're alright then, not entirely sure though. I guess you need a contributor to merge this PR now