Preserve original list-position
, when local/unavailable songs are skipped
#2105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Preserve original
list-position
, when local/unavailable songs are skippedDescription
When downloading with
{list-position}
included in the--output
option.When a local song is ignored, or a song is unavailable, previously the track numbers would shift down to fill the gap; now the track numbers correspond to the list positions in the original playlist.
This pull request is unfinished, as I need feedback on whether this is even a good addition to the project, and whether a new CLI option should be added :)
Related Issue
list-position
, when local/unavailable songs are skipped #2104Motivation and Context
I think that an option to preserve the original number would be beneficial, especially if a user wants to manually include the local tracks, so they won't have to rename the files to fix the numbers.
How Has This Been Tested?
Since this is such a small change, I just ran some manual tests and checked compilation still worked.
Types of Changes
Checklist