Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve original list-position, when local/unavailable songs are skipped #2105

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

dxrcy
Copy link
Contributor

@dxrcy dxrcy commented May 24, 2024

Title

Preserve original list-position, when local/unavailable songs are skipped

Description

When downloading with {list-position} included in the --output option.
When a local song is ignored, or a song is unavailable, previously the track numbers would shift down to fill the gap; now the track numbers correspond to the list positions in the original playlist.

This pull request is unfinished, as I need feedback on whether this is even a good addition to the project, and whether a new CLI option should be added :)

Related Issue

Motivation and Context

I think that an option to preserve the original number would be beneficial, especially if a user wants to manually include the local tracks, so they won't have to rename the files to fix the numbers.

How Has This Been Tested?

Since this is such a small change, I just ran some manual tests and checked compilation still worked.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

Copy link

@lungustefan lungustefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could i get a compiled version of this ?

@dxrcy
Copy link
Contributor Author

dxrcy commented Jun 1, 2024

Could i get a compiled version of this ?

What platform are you on?
Are you not able to compile it yourself?

@dxrcy dxrcy marked this pull request as ready for review June 2, 2024 23:15
@xnetcat xnetcat changed the base branch from master to dev July 20, 2024 10:25
@xnetcat xnetcat merged commit 6890493 into spotDL:dev Jul 20, 2024
1 of 10 checks passed
@xnetcat xnetcat mentioned this pull request Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve original list-position, when local/unavailable songs are skipped
3 participants