single callback video event #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mple-camera-preview into video-single-cb-android
…cordova-plugin-simple-camera-preview into video-single-cb-android
…cordova-plugin-simple-camera-preview into video-single-cb-android
…mple-camera-preview into video-single-cb-android
dinitri
commented
Jul 18, 2024
Comment on lines
303
to
306
| if (recording != null) { | ||
| recording.stop(); | ||
| recording = null; | ||
| } |
There was a problem hiding this comment.
we can stopVideoCapture directly
added 2 commits
July 18, 2024 16:08
dinitri
commented
Jul 22, 2024
src/android/SimpleCameraPreview.java
Outdated
| @@ -92,6 +103,89 @@ public boolean execute(String action, JSONArray args, CallbackContext callbackCo | |||
| } | |||
| } | |||
|
|
|||
| private boolean initVideoCallback(CallbackContext callbackContext) { | |||
| this.videoCallbackContext = callbackContext; | |||
| PluginResult result = new PluginResult(PluginResult.Status.OK, "video cb initialized"); | |||
There was a problem hiding this comment.
Suggested change
| PluginResult result = new PluginResult(PluginResult.Status.OK, "video cb initialized"); | |
| PluginResult result = new PluginResult(PluginResult.Status.OK, "video callback initialized"); |
www/SimpleCameraPreview.js
Outdated
| @@ -43,3 +78,4 @@ SimpleCameraPreview.deviceHasUltraWideCamera = function (onSuccess, onError) { | |||
| }; | |||
|
|
|||
| module.exports = SimpleCameraPreview; | |||
|
|
|||
HashirRajah
approved these changes
Jul 24, 2024
www/SimpleCameraPreview.js
Outdated
| (err) => { | ||
| this.videoCallback(null, err); | ||
| }, | ||
| "SimpleCameraPreview", |
There was a problem hiding this comment.
Suggested change
| "SimpleCameraPreview", | |
| PLUGIN_NAME, |
www/SimpleCameraPreview.js
Outdated
| SimpleCameraPreview.videoInitialized = true; | ||
| this.videoCallback(info); | ||
| } , | ||
| (err) => { |
There was a problem hiding this comment.
Suggested change
| (err) => { | |
| (err) => { |
www/SimpleCameraPreview.js
Outdated
| exec( | ||
| (info) => { | ||
| SimpleCameraPreview.videoInitialized = true; | ||
| this.videoCallback(info); |
There was a problem hiding this comment.
Suggested change
| this.videoCallback(info); | |
| onSuccess(info); |
YushraJewon
reviewed
Jul 30, 2024
www/SimpleCameraPreview.js
Outdated
| @@ -16,17 +16,17 @@ SimpleCameraPreview.startVideoCapture = function (onSuccess, onError) { | |||
| exec( | |||
| (info) => { | |||
| SimpleCameraPreview.videoInitialized = true; | |||
| this.videoCallback(info); | |||
| onSuccess(info); | |||
There was a problem hiding this comment.
this.videoCallback({videocb: "video initialiazed"});
added 2 commits
July 30, 2024 17:18
…mple-camera-preview into video-single-cb-android
dinitri
commented
Aug 2, 2024
www/SimpleCameraPreview.js
Outdated
| exec( | ||
| (info) => { | ||
| SimpleCameraPreview.videoInitialized = true; | ||
| this.videoCallback({ tvideoCallback: true }); |
There was a problem hiding this comment.
tvideoCallback. ?
c'est pas plutot un truc du genre videoCallbackInitialized @YushraJewon
zfir
reviewed
Aug 9, 2024
| @@ -2,6 +2,47 @@ var exec = require("cordova/exec"); | |||
| var PLUGIN_NAME = "SimpleCameraPreview"; | |||
| var SimpleCameraPreview = function () {}; | |||
|
|
|||
| SimpleCameraPreview.videoInitialized = false; | |||
| SimpleCameraPreview.videoCallback = null; | |||
There was a problem hiding this comment.
Suggested change
| SimpleCameraPreview.videoCallback = null; |
I think videoInitialized is enough and storing videoCallback as global is not required
There was a problem hiding this comment.
@zfir we can consider it as a refactoring for the next version
…cordova-plugin-simple-camera-preview into video-single-cb-android
Co-authored-by: Zafir Sk Heerah <[email protected]>
…cordova-plugin-simple-camera-preview into video-single-cb-android
dinitri
commented
Aug 13, 2024
| @@ -2,6 +2,47 @@ var exec = require("cordova/exec"); | |||
| var PLUGIN_NAME = "SimpleCameraPreview"; | |||
| var SimpleCameraPreview = function () {}; | |||
|
|
|||
| SimpleCameraPreview.videoInitialized = false; | |||
| SimpleCameraPreview.videoCallback = null; | |||
There was a problem hiding this comment.
@zfir we can consider it as a refactoring for the next version
dinitri
commented
Aug 19, 2024
| } | ||
|
|
||
| public void stopVideoCapture() { | ||
| if (recording != null) { |
There was a problem hiding this comment.
I think we have to put this,
Suggested change
| if (recording != null) { | |
| if (recording != null && recording == true) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.