Video capture #69

YushraJewon · 2024-03-21T11:35:41Z

Allow plugin to capture video.

zfir · 2024-04-19T11:25:27Z

src/android/CameraPreviewFragment.java

@@ -24,8 +28,18 @@
 import androidx.camera.core.ImageCaptureException;
 import androidx.camera.core.Preview;
 import androidx.camera.lifecycle.ProcessCameraProvider;
+import androidx.camera.video.FileOutputOptions;
+import androidx.camera.video.MediaStoreOutputOptions;


Suggested change

import androidx.camera.video.MediaStoreOutputOptions;

zfir · 2024-04-19T11:33:42Z

src/android/SimpleCameraPreview.java

+            return true;
+        }
+
+        fragment.captureVideo( useFlash, new VideoCallback() {


Suggested change

fragment.captureVideo( useFlash, new VideoCallback() {

fragment.captureVideo(useFlash, new VideoCallback() {

zfir · 2024-04-19T11:34:36Z

src/android/CameraPreviewFragment.java

+       if (torchActivated) {
+           useFlash = true;
+       } else {
+           camera.getCameraControl().enableTorch(useFlash);
+       }


Suggested change

if (torchActivated) {

useFlash = true;

} else {

camera.getCameraControl().enableTorch(useFlash);

}

if (torchActivated) {

useFlash = true;

} else {

camera.getCameraControl().enableTorch(useFlash);

}

Some lines not indented properly xD

zfir · 2024-04-19T11:40:53Z

src/android/CameraPreviewFragment.java

-        } catch (IllegalArgumentException e) {
-            // Error with result in capturing image with default resolution
-            e.printStackTrace();
+        this.getActivity().runOnUiThread(() -> {


Suggested change

this.getActivity().runOnUiThread(() -> {

this.getActivity().runOnUiThread(() -> {

Why do we need to run this on UI thread?

zfir · 2024-04-19T11:41:07Z

src/android/CameraPreviewFragment.java

+                .withAudioEnabled()
+                .start(ContextCompat.getMainExecutor(this.getContext()), videoRecordEvent -> {
+                    if (videoRecordEvent instanceof VideoRecordEvent.Start) {
+                        videoCallback.onStart(null,true, null);


Suggested change

videoCallback.onStart(null,true, null);

videoCallback.onStart(null, true, null);

parveshneedhoo · 2024-05-22T06:29:07Z

src/android/CameraPreviewFragment.java

@@ -102,9 +124,9 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
        return containerView;
    }

+


Suggested change

parveshneedhoo · 2024-05-22T06:32:09Z

src/android/CameraPreviewFragment.java

            );
-        }
+            }
+


Suggested change

…mple-camera-preview into video-rrecording

HashirRajah · 2024-05-28T06:33:08Z

src/android/SimpleCameraPreview.java

+                }
+            }
+
+            public void onStop(Exception err, Boolean started, String nativePath) {


Suggested change

public void onStop(Exception err, Boolean started, String nativePath) {

public void onStop(Exception err, Boolean recording, String nativePath) {

The parameter is named recording in the interface. Should we keep the name as recording?

HashirRajah · 2024-05-28T07:31:42Z

src/android/CameraPreviewFragment.java

+                            // Handle video saved
+                            videoCallback.onStop(null, false, Uri.fromFile(videoFile).toString());
+                            Uri savedUri = finalizeEvent.getOutputResults().getOutputUri();
+                            Log.d(TAG, "Video saved to: " + savedUri);


Suggested change

Log.d(TAG, "Video saved to: " + savedUri);

Log.i(TAG, "Video saved to: " + savedUri);

HashirRajah · 2024-05-28T07:33:44Z

src/android/CameraPreviewFragment.java

+    void onStart(Exception err,Boolean recording, String nativePath);
+    void onStop(Exception err, Boolean recording, String nativePath);


We are not using the parameter Exception err when defining the callbacks. Should we remove it?

HashirRajah · 2024-05-28T07:38:58Z

src/android/CameraPreviewFragment.java

+        if (torchActivated) {
+            useFlash = true;
+        } else {
+            camera.getCameraControl().enableTorch(useFlash);
+        }


Suggested change

if (torchActivated) {

useFlash = true;

} else {

camera.getCameraControl().enableTorch(useFlash);

}

if (!torchActivated) {

camera.getCameraControl().enableTorch(useFlash);

}

This will work right?
In the if block, useFlash is being reassigned but we the argument is used only in the else block.

…pture

zfir · 2024-05-29T08:50:04Z

src/android/CameraPreviewFragment.java

@@ -258,6 +277,54 @@ public void hasFlash(HasFlashCallback hasFlashCallback) {
        hasFlashCallback.onResult(camera.getCameraInfo().hasFlashUnit());
    }

+    public void captureVideo(VideoCallback videoCallback) {
+        if (recording != null) {
+            recording.stop();


Suggested change

recording.stop();

recording.stop();

recording = null;

zfir · 2024-05-29T08:51:50Z

src/android/CameraPreviewFragment.java

+        ContentValues contentValues = new ContentValues();
+        contentValues.put(MediaStore.Video.Media.DISPLAY_NAME, filename);


Suggested change

ContentValues contentValues = new ContentValues();

contentValues.put(MediaStore.Video.Media.DISPLAY_NAME, filename);

ContentValues contentValues = new ContentValues();

contentValues.put(MediaStore.Video.Media.DISPLAY_NAME, filename);

not used

zfir · 2024-05-29T08:52:21Z

src/android/CameraPreviewFragment.java

+            ActivityCompat.requestPermissions(this.getActivity(), new String[]{Manifest.permission.RECORD_AUDIO}, 200);
+        }
+        File videoFile = new File(
+                getContext().getApplicationContext().getFilesDir(),


Suggested change

getContext().getApplicationContext().getFilesDir(),

getContext().getFilesDir(),

zfir · 2024-05-29T08:55:58Z

src/android/CameraPreviewFragment.java

+                            Log.e(TAG, "Video recording error: " + errorCode, errorCause);
+                        } else {
+                            // Handle video saved
+                            videoCallback.onStop(false, Uri.fromFile(videoFile).toString());


Better to move this line after the log(line 317)

parveshneedhoo

For audio permission deny part, we can treat it same as we do for image picker.

Before starting video capture :
1)we first request permission
2)then we check if it has permission
3) if it has, we start recording withAudioEnabled else start it without

parveshneedhoo · 2024-05-29T11:59:08Z

src/android/CameraPreviewFragment.java

+                            videoCallback.onStop(false, Uri.fromFile(videoFile).toString());
+                            Uri savedUri = finalizeEvent.getOutputResults().getOutputUri();
+                            Log.i(TAG, "Video saved to: " + savedUri);
+                            recording = null;


move this on line 325? since we are not setting the recording to null if finalizeEvent.hasError()

…mple-camera-preview into video-rrecording

…eo initialized

video capture test

2ea8b74

YushraJewon self-assigned this Mar 21, 2024

YushraJewon added 4 commits March 22, 2024 11:26

add missing imports

fb341a5

add camera-video in plugin xml

8c139a5

remove space

3aa4f2f

setQuality lowest and remove toast

ddcce21

zfir reviewed Apr 19, 2024

View reviewed changes

parveshneedhoo reviewed May 22, 2024

View reviewed changes

YushraJewon added 4 commits May 24, 2024 07:55

Merge branch 'master' of github.com:spoonconsulting/cordova-plugin-si…

b3a39f0

…mple-camera-preview into video-rrecording

indentation and suggestions

7ce1e7a

resolve conflict move videoRecorder setup in setUp camera

d87739f

indent

03d77e9

YushraJewon requested review from zfir, dinitri, sc-nick, HashirRajah and parveshneedhoo May 28, 2024 06:05

HashirRajah reviewed May 28, 2024

View reviewed changes

YushraJewon added 2 commits May 28, 2024 15:04

remove exception err from videoCallback and remove torch from videoCa…

b891b4c

…pture

remove flash from js options

029c815

zfir reviewed May 29, 2024

View reviewed changes

parveshneedhoo reviewed May 29, 2024

View reviewed changes

YushraJewon added 7 commits May 30, 2024 14:01

remove unused codes and set recording null after recording

041a975

separate start and stop video capture

fd3f009

stopVideoCapture

a67b68d

Merge branch 'master' of github.com:spoonconsulting/cordova-plugin-si…

004489f

…mple-camera-preview into video-rrecording

using a single callback

27c03ad

Merge branch 'master' of github.com:spoonconsulting/cordova-plugin-si…

3594f47

…mple-camera-preview into video-rrecording

remove first line define plugin and set videocallback to null and vid…

9667c56

…eo initialized

YushraJewon closed this Jul 31, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Video capture #69

Video capture #69

YushraJewon commented Mar 21, 2024

zfir Apr 19, 2024

zfir Apr 19, 2024

zfir Apr 19, 2024

zfir Apr 19, 2024

zfir Apr 19, 2024

parveshneedhoo May 22, 2024

parveshneedhoo May 22, 2024

HashirRajah May 28, 2024

HashirRajah May 28, 2024

HashirRajah May 28, 2024

HashirRajah May 28, 2024

zfir May 29, 2024

zfir May 29, 2024

zfir May 29, 2024

zfir May 29, 2024

parveshneedhoo left a comment

parveshneedhoo May 29, 2024

	fragment.captureVideo( useFlash, new VideoCallback() {
	fragment.captureVideo(useFlash, new VideoCallback() {

	this.getActivity().runOnUiThread(() -> {
	this.getActivity().runOnUiThread(() -> {

	videoCallback.onStart(null,true, null);
	videoCallback.onStart(null, true, null);

		@@ -102,9 +124,9 @@ public View onCreateView(@NonNull LayoutInflater inflater, @Nullable ViewGroup c
		return containerView;
		}

	public void onStop(Exception err, Boolean started, String nativePath) {
	public void onStop(Exception err, Boolean recording, String nativePath) {

	Log.d(TAG, "Video saved to: " + savedUri);
	Log.i(TAG, "Video saved to: " + savedUri);

		void onStart(Exception err,Boolean recording, String nativePath);
		void onStop(Exception err, Boolean recording, String nativePath);

		ContentValues contentValues = new ContentValues();
		contentValues.put(MediaStore.Video.Media.DISPLAY_NAME, filename);

	getContext().getApplicationContext().getFilesDir(),
	getContext().getFilesDir(),

Video capture #69

Video capture #69

Conversation

YushraJewon commented Mar 21, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parveshneedhoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment