use onsuccess and other suggestions

spoonconsulting · Jul 25, 2024 · 1eef24e · 1eef24e
1 parent 0452c69
commit 1eef24e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/android/SimpleCameraPreview.java b/src/android/SimpleCameraPreview.java
@@ -105,7 +105,7 @@ public boolean execute(String action, JSONArray args, CallbackContext callbackCo
 
     private boolean initVideoCallback(CallbackContext callbackContext) {
         this.videoCallbackContext = callbackContext;
-        PluginResult result = new PluginResult(PluginResult.Status.OK, "video cb initialized");
+        PluginResult result = new PluginResult(PluginResult.Status.OK, "video callback initialized");
         result.setKeepCallback(true);
         this.videoCallbackContext.sendPluginResult(result);
         return true;

diff --git a/www/SimpleCameraPreview.js b/www/SimpleCameraPreview.js
@@ -16,17 +16,17 @@ SimpleCameraPreview.startVideoCapture = function (onSuccess, onError) {
     exec(
         (info) => {
           SimpleCameraPreview.videoInitialized = true;
-          this.videoCallback(info);
+          onSuccess(info);
         } ,
-          (err) => {
-            this.videoCallback(null, err);
+        (err) => {
+          this.videoCallback(null, err);
         },
-        "SimpleCameraPreview",
+        PLUGIN_NAME,
         "initVideoCallback",
         []
     );
   }
-  exec(onSuccess, onError, PLUGIN_NAME, "startVideoCapture");
+  exec(() => {}, onError, PLUGIN_NAME, "startVideoCapture");
 };
 
 SimpleCameraPreview.stopVideoCapture = function (onSuccess, onError) {
@@ -78,4 +78,3 @@ SimpleCameraPreview.deviceHasUltraWideCamera = function (onSuccess, onError) {
 };
 
 module.exports = SimpleCameraPreview;
-