Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Security Assistant: Reduces the public API surface & improves code coverage #15

Merged
merged 1 commit into from
May 26, 2023
Merged

[Security Solution] Security Assistant: Reduces the public API surface & improves code coverage #15

merged 1 commit into from
May 26, 2023

Conversation

andrew-goldstein
Copy link
Collaborator

[Security Solution] Security Assistant: Reduces the public API surface & improves code coverage

  • Reduces the public API surface
  • improves code coverage

@andrew-goldstein
- reduces the public API surface
7f39719 
- improves code coverage
- updates types and tests
- updates translations
- updates welcome translation ids
spong
spong approved these changes May 26, 2023
View reviewed changes
Copy link
Owner

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair reviewed over zoom -- looks absolutely fantastic to this dev! 😀 🚀

@spong spong merged commit 578fb89 into spong:security-assistant-playground May 26, 2023
@andrew-goldstein andrew-goldstein deleted the improves-code-coverage branch May 26, 2023 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-goldstein @spong