-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrubbing check during recording video buffering metric #9
Comments
This is actually something I debated for a while when writing this portion. I started looking for what I wanted to answer in the metrics. Specifically for buffering, I was largely answering the questions:
Users who used the scrub bar are basically reloading the video with intent, so those users didn't matter in that analysis (for my use-case). I can certainly see your use-case. I am open to receiving a Pull Request that would solve your issue. I'd want backwards compatibility -- so possibly adding an option.. videojs('videodomid', {
...videoConfig,
plugins: {
eventTracking: {
bufferingConfig: { includeScrub: false }
}
}
}); |
I understand your viewpoint. I'll work on a PR for providing the scrub configuration. |
released to npmjs: 1.0.1 thank you for the contribution! |
Hi.
My question was related to the following behavior:
Regards,
Subhendu
The text was updated successfully, but these errors were encountered: