Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrubbing check during recording video buffering metric #9

Closed
subhendusethi opened this issue Dec 1, 2019 · 3 comments
Closed

Scrubbing check during recording video buffering metric #9

subhendusethi opened this issue Dec 1, 2019 · 3 comments

Comments

@subhendusethi
Copy link
Contributor

Hi.

My question was related to the following behavior:

  • Why do we have the check on scrubbing for recording buffering metric? The reason I am asking is that whenever I am seeking the video to a considerable timestamp forward or backward the video player is waiting/buffering and because of this check I am losing on that important data point.

Regards,
Subhendu

@spodlecki
Copy link
Owner

This is actually something I debated for a while when writing this portion. I started looking for what I wanted to answer in the metrics. Specifically for buffering, I was largely answering the questions:

How many users while playing a video, experienced buffering?
How long were these users in a buffering state?

Users who used the scrub bar are basically reloading the video with intent, so those users didn't matter in that analysis (for my use-case).


I can certainly see your use-case. I am open to receiving a Pull Request that would solve your issue. I'd want backwards compatibility -- so possibly adding an option..

videojs('videodomid', {
    ...videoConfig,
    plugins: {
      eventTracking: {
        bufferingConfig: { includeScrub: false }
      }
    }
});

@subhendusethi
Copy link
Contributor Author

I understand your viewpoint. I'll work on a PR for providing the scrub configuration.

@spodlecki
Copy link
Owner

spodlecki commented Dec 3, 2019

released to npmjs: 1.0.1

thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants