Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bufferingConfig to include scrub events while computing buffering metrics #10

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

subhendusethi
Copy link
Contributor

PR for the issue.

This issue adds a backwards compatible and optional configuration, to consider computation of buffering metrics when the user is scrubbing on the video player.

The configuration can be set manually by the user while initializing the eventTracking plugin:

player.eventTracking({
    bufferingConfig: {
      includeScrub: true
    }

Tested with/without the scrub config in both chrome and firefox. Buffering metrics are getting computed as per expected.

npm run test : SUCCESS

@spodlecki spodlecki merged commit 2f2fac7 into spodlecki:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants