Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single space into CannotCreateMockException message #1402

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

T45K
Copy link
Contributor

@T45K T45K commented Dec 7, 2021

I faced occurrence of CannotCreateMockException in my project.
Its error message was like Cannot create mock for class myPackage.MyClassnull.
I think MyClassnull in the message should be split into two words, MyClass and null for understandability.

@leonard84 leonard84 enabled auto-merge (squash) December 7, 2021 21:16
@leonard84
Copy link
Member

Thanks @T45K

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #1402 (911f202) into master (fb6361f) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1402      +/-   ##
============================================
- Coverage     79.36%   79.31%   -0.05%     
+ Complexity     3987     3986       -1     
============================================
  Files           403      401       -2     
  Lines         12413    12408       -5     
  Branches       1639     1637       -2     
============================================
- Hits           9852     9842      -10     
- Misses         1968     1974       +6     
+ Partials        593      592       -1     
Impacted Files Coverage Δ
...spockframework/mock/CannotCreateMockException.java 66.66% <100.00%> (ø)
...ckframework/mock/runtime/ByteBuddyMockFactory.java 66.66% <0.00%> (-15.69%) ⬇️
.../spockframework/util/StringMessagePrintStream.java 80.00% <0.00%> (-3.08%) ⬇️
...aus/groovy/ast/expr/MethodReferenceExpression.java
...org/codehaus/groovy/ast/expr/LambdaExpression.java
...n/groovy/org/spockframework/util/GroovyUtil.groovy 85.71% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb6361f...911f202. Read the comment docs.

@leonard84 leonard84 merged commit 39fdb8b into spockframework:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants