-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression with multi-assignment of method call result #1333
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1333 +/- ##
=============================================
+ Coverage 0 79.22% +79.22%
- Complexity 0 3943 +3943
=============================================
Files 0 408 +408
Lines 0 12262 +12262
Branches 0 1617 +1617
=============================================
+ Hits 0 9714 +9714
- Misses 0 1967 +1967
- Partials 0 581 +581
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, except for the massive amount of unrelated whitespace changes.
This makes review very hard and also seeing the real change later when browsing the history.
Could you consider reverting all the unrelated whitespace changes and maybe reformat the whole codebase with the settings you want to have within an own commit?
Yeah didn't notice the whitespace change, I really need to make the reformat commit for the whole codebase. |
@leonard84 Any estimations when this fix will be released? |
caused by #1314
fixes #1332