Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with multi-assignment of method call result #1333

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

leonard84
Copy link
Member

caused by #1314

fixes #1332

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #1333 (4af9f3b) into master (ac2afc8) will increase coverage by 79.22%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #1333       +/-   ##
=============================================
+ Coverage          0   79.22%   +79.22%     
- Complexity        0     3943     +3943     
=============================================
  Files             0      408      +408     
  Lines             0    12262    +12262     
  Branches          0     1617     +1617     
=============================================
+ Hits              0     9714     +9714     
- Misses            0     1967     +1967     
- Partials          0      581      +581     
Impacted Files Coverage Δ
...java/org/spockframework/compiler/SpecRewriter.java 94.42% <100.00%> (ø)
...ovy/spock/util/concurrent/BlockingVariables.groovy 80.00% <0.00%> (ø)
.../runtime/extension/builtin/NarrativeExtension.java 100.00% <0.00%> (ø)
.../main/java/org/spockframework/util/JsonWriter.java 89.76% <0.00%> (ø)
...pockframework/runtime/GlobalExtensionRegistry.java 91.39% <0.00%> (ø)
.../src/main/java/spock/mock/DetachedMockFactory.java 100.00% <0.00%> (ø)
...org/spockframework/runtime/PlatformSpecRunner.java 92.82% <0.00%> (ø)
...ava/org/spockframework/util/GroovyReleaseInfo.java 66.66% <0.00%> (ø)
...work/runtime/extension/builtin/IssueExtension.java 86.66% <0.00%> (ø)
...tension/builtin/PendingFeatureSuccessfulError.java 100.00% <0.00%> (ø)
... and 399 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac2afc8...4af9f3b. Read the comment docs.

Vampire
Vampire previously approved these changes May 21, 2021
Copy link
Member

@Vampire Vampire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, except for the massive amount of unrelated whitespace changes.
This makes review very hard and also seeing the real change later when browsing the history.
Could you consider reverting all the unrelated whitespace changes and maybe reformat the whole codebase with the settings you want to have within an own commit?

@leonard84
Copy link
Member Author

Yeah didn't notice the whitespace change, I really need to make the reformat commit for the whole codebase.

@kriegaex
Copy link
Contributor

Lgtm, except for the massive amount of unrelated whitespace changes.

Maybe this helps, if something like this happens again unintentionally:
image

@iNikem
Copy link

iNikem commented Oct 2, 2021

@leonard84 Any estimations when this fix will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants