Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SYN-4427: Add omitempty field for WaitForNavTimeout #27

Merged
merged 2 commits into from
Sep 17, 2024
Merged

SYN-4427: Add omitempty field for WaitForNavTimeout #27

merged 2 commits into from
Sep 17, 2024

Conversation

nitun-splunk
Copy link
Contributor

@nitun-splunk nitun-splunk commented Sep 17, 2024 •
edited
Loading

Resolves #ISSUE_NUMBER

Before the change?

  • WaitForNavTimeout was default set to 0 if we set it to null or remove this field, which cause immidiate timeout

After the change?

  • this will set filed to null or empty after this changes.

Pull request checklist

  • Acceptance Tests have been updated, run (make testacc), and pasted in this PR (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Acceptance Test Output

Does this introduce a breaking change?

  • Yes
  • No

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nitun-splunk
Copy link
Contributor Author

recheck

@nitun-splunk
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

srv-gh-tools added a commit to splunk/cla-agreement that referenced this pull request Sep 17, 2024
@srv-gh-tools
@nitun-splunk has signed the CLA in splunk/syntheticsclient#27
92dd206
@nitun-splunk
Copy link
Contributor Author

recheck

@nitun-splunk
Copy link
Contributor Author

I have read the Code of Conduct and I hereby accept the Terms

@sangn-splunk sangn-splunk merged commit 742c35d into splunk:v2 Sep 17, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sangn-splunk sangn-splunk sangn-splunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nitun-splunk @sangn-splunk