Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYN-3197: Custom Properties #11

Conversation

bgustafson
Copy link
Contributor

Adds custom properties for tests. This is an optional field that is currently behind a feature flag.

@bgustafson bgustafson marked this pull request as draft October 12, 2023 14:07
@bgustafson bgustafson marked this pull request as ready for review October 12, 2023 14:07
@bgustafson bgustafson marked this pull request as draft October 12, 2023 14:07
Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind adding the new fields to the integration test bodies?

Otherwise this all LGTM! Let me know when you're closer to GA on this addition.

@bgustafson bgustafson marked this pull request as ready for review November 13, 2023 14:55
Copy link
Collaborator

@greatestusername-splunk greatestusername-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Thanks for adding this!

@greatestusername-splunk greatestusername-splunk merged commit 68e4c5d into splunk:main Nov 14, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants