Add support for custom event body serializer #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Customizable & pluggable event serializer support for the HttpEventCollectorAdapter.
robinjhector
changed the title
|
Hmm, Travis tests seems to fail because of an invalid HEC token. Not sure if I can solve those |
|
Thank you for this work @izrobin! I took a quick look and this looks like a reasonable approach. We'll look into the CI issues when we get some spare cycles. |
|
Hi All, Any update on this one? I was about ready to do pretty much the same thing (in our case to limit the message size so HEC would always get well formed json). thanks dave |
Merged
|
@zvaavtre I merged the PR to develop branch. We will do a release including this change soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After playing around with the library a few days, I found that at the current time, it's impossible to simply send the log message over HEC to splunk. By default, the logging adapter builds a rich json object with metadata fields such as
severity,thread(name) etc.I googled around online, and it seems like quite a few would like the possibility to format the message before sending the event payload. (Including #79)
Hence, I'm suggesting adding support to plug your own
EventBodySerializer. Feedback very much appriciated.Also made the
HttpEventCollectorSenderpublic & non-final for even more customisation support.