Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add additional event attributes #28

Conversation

afinkenstadt
Copy link
Contributor

In addition to #25 , this pull request adds support for the additional and useful portions of the logger interfaces provided by LogBack, SLF4J, and java. logging. utils:

logger_name
thread_name (or ID)
and the Context maps.

Includes tests to confirm.

@joshgarnett
Copy link

+1

@afinkenstadt
Copy link
Contributor Author

Fixes #26

@afinkenstadt
Copy link
Contributor Author

CLA signed.

@shakeelmohamed
Copy link
Contributor

@afinkenstadt can we close this in favor of #29?

@afinkenstadt
Copy link
Contributor Author

We can; but merging in #29 will automatically close #28 and #25. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants