When you synchronize on a field, it should be final

splunk · Oct 25, 2021 · 10c38ba · 10c38ba
1 parent da75176
commit 10c38ba
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/test/java/HttpEventCollector_JavaLoggingTest.java b/src/test/java/HttpEventCollector_JavaLoggingTest.java
@@ -30,8 +30,8 @@
 public final class HttpEventCollector_JavaLoggingTest {
 
     private String httpEventCollectorName = "JavaLoggingTest";
-    List<List<HttpEventCollectorEventInfo>> errors = new ArrayList<>();
-    List<HttpEventCollectorErrorHandler.ServerErrorException> logEx = new ArrayList<>();
+    private final List<List<HttpEventCollectorEventInfo>> errors = new ArrayList<>();
+    private final List<HttpEventCollectorErrorHandler.ServerErrorException> logEx = new ArrayList<>();
 
     /**
      * sending a message via httplogging using java.logging to splunk

diff --git a/src/test/java/HttpEventCollector_Log4j2Test.java b/src/test/java/HttpEventCollector_Log4j2Test.java
@@ -30,8 +30,8 @@
 
 public final class HttpEventCollector_Log4j2Test {
     private String httpEventCollectorName = "Log4j2Test";
-    List<List<HttpEventCollectorEventInfo>> errors = new ArrayList<>();
-    List<HttpEventCollectorErrorHandler.ServerErrorException> logEx = new ArrayList<>();
+    private final List<List<HttpEventCollectorEventInfo>> errors = new ArrayList<>();
+    private final List<HttpEventCollectorErrorHandler.ServerErrorException> logEx = new ArrayList<>();
 
     /**
      * sending a message via httplogging using log4j2 to splunk

diff --git a/src/test/java/HttpEventCollector_LogbackTest.java b/src/test/java/HttpEventCollector_LogbackTest.java
@@ -30,8 +30,8 @@
 public final class HttpEventCollector_LogbackTest {
 
     private String httpEventCollectorName = "LogbackTest";
-    List<List<HttpEventCollectorEventInfo>> errors = new ArrayList<>();
-    List<HttpEventCollectorErrorHandler.ServerErrorException> logEx = new ArrayList<>();
+    private final List<List<HttpEventCollectorEventInfo>> errors = new ArrayList<>();
+    private final List<HttpEventCollectorErrorHandler.ServerErrorException> logEx = new ArrayList<>();
 
     /**
      * sending a message via httplogging using logback to splunk