Feature: Multi-arch images #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| builder: ${{ steps.buildx.outputs.name }} | ||
| context: . | ||
| file: ./docker/Dockerfile | ||
| platforms: linux/amd64 |
mwang2016
reviewed
Oct 28, 2021
.github/workflows/ci_build_test.yaml
Outdated
| id: prep | ||
| run: | | ||
| VERSION=`cat VERSION` | ||
| TAGS=splunk/k8s-metrics:$GITHUB_RUN_ID |
There was a problem hiding this comment.
Hi @hbrewster-splunk , if we use "splunk/k8s-metrics:$GITHUB_RUN_ID" as the image tags, we will have to make the change on this file: ci_scripts/deploy_connector.sh (line 21)
--set splunk-kubernetes-metrics.image.repository=k8s-metrics \
to --set splunk-kubernetes-metrics.image.tag=$GITHUB_RUN_ID \
mwang2016
approved these changes
Oct 29, 2021
hbrewster-splunk
force-pushed
the
feature/multi-arch-images
branch
from
a02dff6
to
014096e
Compare
hbrewster-splunk
force-pushed
the
feature/multi-arch-images
branch
from
014096e
to
9eef302
Compare
mwang2016
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Splunk Observability needs to support multi architectural images. As an example use case, when we have a multi-architectural (arm64, amd64) node pool, the splunk-connect splunk-kubernetes-metrics DaemonSet requires a multi-arch image to run successfully.
In this PR @jsun-splunk and I have made alterations to the Dockerfile and GitHub workflow to support building a multi architectural image with docker buildx.
This repository does not contain CD for this image: we will need to discuss changes in the current CD process to support deployment from buildx. Note: (Please See [Ref 1] in PR code) The docker/build-push-action@v2 actions step does not currently support the buildx load options when there are used in conjunction with multiple build platforms (see: docker/buildx#59) . Hence for the purpose of this PR I have listed linux/amd64 only.
We have validated similar changes on all containers in splunk-connect-for-kubernetes and will be happy to raise PRs as appropriate once we have got this one right!
This PR
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.We have built and deployed this container on a multi-architecture node pool as part of splunk-connect-for-kubernetes