Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add site_name to bunit field #13

Closed
ZachChristensen28 opened this issue Sep 7, 2022 · 0 comments · Fixed by #10
Closed

Add site_name to bunit field #13

ZachChristensen28 opened this issue Sep 7, 2022 · 0 comments · Fixed by #10
Labels
feature request New feature or request fixed in next release Issue or feature requested is fixed in the next release.

Comments

@ZachChristensen28
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The current bunit field is mapped to the OU from Falcon. I would also like to see the site_name added to that field.

Describe the solution you'd like
Add falcon_device.site_name to existing bunit field.

Describe alternatives you've considered
n/a

Additional context
n/a

@ZachChristensen28 ZachChristensen28 added the feature request New feature or request label Sep 7, 2022
@ZachChristensen28 ZachChristensen28 self-assigned this Sep 7, 2022
ZachChristensen28 added a commit that referenced this issue Sep 7, 2022
Signed-off-by: Zach Christensen <[email protected]>
ZachChristensen28 added a commit that referenced this issue Sep 7, 2022
Signed-off-by: Zach Christensen <[email protected]>
ZachChristensen28 added a commit that referenced this issue Sep 7, 2022
changes for #13

Signed-off-by: Zach Christensen <[email protected]>
@ZachChristensen28 ZachChristensen28 linked a pull request Sep 7, 2022 that will close this issue
@ZachChristensen28 ZachChristensen28 added the fixed in next release Issue or feature requested is fixed in the next release. label Sep 7, 2022
ZachChristensen28 added a commit that referenced this issue Mar 27, 2023
[//]: # (dependabot-start)
⚠️  **Dependabot is rebasing this PR** ⚠️ 

Rebasing might not happen immediately, so don't worry if this takes some
time.

Note: if you make any changes to this PR yourself, they will take
precedence over the rebase.

---

[//]: # (dependabot-end)

Bumps [mkdocs-glightbox](https://github.com/Blueswen/mkdocs-glightbox)
from 0.3.1 to 0.3.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/Blueswen/mkdocs-glightbox/releases">mkdocs-glightbox's
releases</a>.</em></p>
<blockquote>
<h2>mkdocs-glightbox-0.3.2</h2>
<ul>
<li>Supported image without extension (<a
href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/13">#13</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/blueswen/mkdocs-glightbox/blob/main/CHANGELOG">mkdocs-glightbox's
changelog</a>.</em></p>
<blockquote>
<p>mkdocs-glightbox-0.3.2 (2023-03-19)</p>
<pre><code>* Supported image without extension
([#13](blueswen/mkdocs-glightbox#13))
</code></pre>
<p>mkdocs-glightbox-0.3.1 (2022-11-22)</p>
<pre><code>* Supported lightbox slide effect customization
([#8](blueswen/mkdocs-glightbox#8))
* Supported synchronized lightbox caption dark mode with Material for
MkDocs ([#7](blueswen/mkdocs-glightbox#7))
* Supported glightbox built-in gallery feature
([#11](blueswen/mkdocs-glightbox#11))
* Supported skip image in the anchor tag
</code></pre>
<p>mkdocs-glightbox-0.3.0 (2022-09-29)</p>
<pre><code>* Fixed width and height setting in config not working bug
* Supported specific skip class
([#5](blueswen/mkdocs-glightbox#5))
* Supported glightbox built-in caption with title and description
([#4](blueswen/mkdocs-glightbox#4))
* Fixed page jitter when lightbox closing issue using Material for
MkDocs
* Add white background for lightbox images to prevent the displaying
issue of the transparent image on black background
</code></pre>
<p>mkdocs-glightbox-0.2.1 (2022-08-10)</p>
<pre><code>* Updated readme
</code></pre>
<p>mkdocs-glightbox-0.2.0 (2022-08-10)</p>
<pre><code>* Added support for disabling glightbox with image class or
page meta ([#2](blueswen/mkdocs-glightbox#2))
</code></pre>
<p>mkdocs-glightbox-0.1.7 (2022-07-26)</p>
<pre><code>* Fixed
[#1](blueswen/mkdocs-glightbox#1): Ignore
Emojis
</code></pre>
<p>mkdocs-glightbox-0.1.6 (2022-07-16)</p>
<pre><code>* Fixed some options not working bug
</code></pre>
<p>mkdocs-glightbox-0.1.5 (2022-07-16)</p>
<pre><code>* Fixed mkdocs-material header + sidebar vanishing issue when
opening lightbox (Inspired from
biati-digital/glightbox#22)
* Fixed mkdocs-material content shrinking causing footer offset issue
when open lightbox
* Supported compatible with mkdocs-material Instant loading feature
</code></pre>
<p>mkdocs-glightbox-0.1.4 (2022-06-12)</p>
<pre><code>* Fixed assets location bug
</code></pre>
<p>mkdocs-glightbox-0.1.3 (2022-06-10)</p>
<pre><code>* First release
</code></pre>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/blueswen/mkdocs-glightbox/commit/0c0a5805d8682318e4303299a5e42e637eca4afe"><code>0c0a580</code></a>
Support image without extension (<a
href="https://redirect.github.com/Blueswen/mkdocs-glightbox/issues/13">#13</a>)</li>
<li><a
href="https://github.com/blueswen/mkdocs-glightbox/commit/32b013fa2f9492478bb08b0a88afc63221618168"><code>32b013f</code></a>
Create .github/FUNDING.yml</li>
<li><a
href="https://github.com/blueswen/mkdocs-glightbox/commit/604f9349d5a16fa6f0a3e7e40fef89c1ec35569f"><code>604f934</code></a>
Add building whl</li>
<li><a
href="https://github.com/blueswen/mkdocs-glightbox/commit/104b17ab7fe6dd0a7ab474529e651004e93a99ab"><code>104b17a</code></a>
Update docs</li>
<li><a
href="https://github.com/blueswen/mkdocs-glightbox/commit/da38c2b56b37335ead7387223ee7525a4a2a1244"><code>da38c2b</code></a>
update docs</li>
<li><a
href="https://github.com/blueswen/mkdocs-glightbox/commit/67222b518aa402f904ecbddfc2d6916239ddc77e"><code>67222b5</code></a>
update branch name and add workflow_dispatch</li>
<li>See full diff in <a
href="https://github.com/Blueswen/mkdocs-glightbox/compare/v0.3.1...v0.3.2">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=mkdocs-glightbox&package-manager=pip&previous-version=0.3.1&new-version=0.3.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Zach Christensen <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Zach Christensen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request fixed in next release Issue or feature requested is fixed in the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant