Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token not persisting when limits is missing #392

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Conversation

dloucasfx
Copy link
Collaborator

This bug has been around for years but it's only exposed when entitlement is missing the tokenLimits feature.
The json response for token creation against an org with no tokenLimits will look like this (note: "limits" : {... is missing )

{
  "authScopes" : [ "INGEST", "API" ],
  "created" : 1662988122213,
  "description" : "test",
  "disabled" : false,
  "expiry" : 1662988122213,
  "id" : "xxxxxx",
  "lastUpdated" : 1662988122213,
  "lastUpdatedBy" : null,
  "latestRotation" : 1662988122213,
  "name" : "test",
  "permissions" : null,
  "secret" : "xxxxxx"
}

With limits missing, the provider will skip persisting the token and notifications

Fixes: #310

Signed-off-by: Dani Louca [email protected]

@dloucasfx dloucasfx merged commit 738b946 into main Sep 13, 2022
@atoulme atoulme deleted the SWAT-5055 branch May 2, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

signalfx_org_token secret attribute does not work
3 participants