Fix token not persisting when limits is missing #392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug has been around for years but it's only exposed when entitlement is missing the
tokenLimits
feature.The json response for token creation against an org with no
tokenLimits
will look like this (note:"limits" : {...
is missing )With
limits
missing, the provider will skip persisting thetoken
andnotifications
Fixes: #310
Signed-off-by: Dani Louca [email protected]