Add label_resolutions to signalfx_detector resource
#338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdecat
force-pushed
the
detection_resolution
branch
2 times, most recently
from
83dd37d
to
fda2941
Compare
pdecat
commented
Jan 25, 2022
pdecat
force-pushed
the
detection_resolution
branch
from
fda2941
to
4a9e0b9
Compare
keitwb
reviewed
Jan 28, 2022
go.mod
Outdated
| @@ -6,7 +6,7 @@ require ( | |||
| github.com/bgentry/go-netrc v0.0.0-20140422174119-9fd32a8b3d3d | |||
| github.com/hashicorp/terraform-plugin-sdk v1.15.0 | |||
| github.com/mitchellh/go-homedir v1.1.0 | |||
| github.com/signalfx/signalfx-go v1.8.3 | |||
| github.com/signalfx/signalfx-go v1.8.5-0.20220125181716-88f2f325c069 | |||
There was a problem hiding this comment.
I did a proper release of 1.8.5 in signalfx-go, so can you change it here to use the new tag?
pdecat
force-pushed
the
detection_resolution
branch
from
4a9e0b9
to
56afd96
Compare
pdecat
force-pushed
the
detection_resolution
branch
from
56afd96
to
9223de4
Compare
|
Hi @keitwb, could you take another look at this PR? |
|
Once again thank you @pdecat for a nice work! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
label_resolutionsas a computed attribute of thesignalfx_detectorresource.See https://dev.splunk.com/observability/reference/api/detectors/latest#endpoint-retrieve-detectors-query
and
TODO: