-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump minitest versions to 5.14.3 #148
Conversation
The nokogiri build failed because the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the files in gemfiles/*
are generated by a gem called Appraisal. There is "master list" kept in the Appraisals
file. You can see that it's sort of a gemfile of gemfiles, where a set of gems is grouped by Rails and RSpec version. So, if you want to add a new gem, it's better to add it to one or more groups instead. Then you can run appraisal install
on the command line to install all gems in all groups.
Thanks for the tip on |
Could you run the workflow again to see if this fixes the build? |
It turns out that you cannot use
|
This passed finally it looks like, could you merge this and I can bring it into the other PRs? |
TIL about |
On #146 I was getting spec failures because the locked version of minitest does not work with rails 3.1.1, so bumping to one that should work: https://github.com/seattlerb/minitest/blob/master/History.rdoc#5143--2021-01-05-