Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v1.0.1 #132

Merged
merged 12 commits into from
Nov 11, 2024
Merged

Conversation

EmilianoSanchez
Copy link
Contributor

JS Browser SDK

What did you accomplish?

  • Revert removal of TypeScript SplitIO namespace at /types/splitio.d.ts to allow explicit imports of types from the Browser SDK package. E.g., import type { IClientSideSettings } from '@splitsoftware/splitio-browserjs/types/splitio';.

How do we test the changes introduced in this PR?

  • Added asserts in TS tests.

Extra Notes

@EmilianoSanchez EmilianoSanchez requested a review from a team as a code owner November 7, 2024 16:57
Copy link
Contributor

@lenasano lenasano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small and quick changes suggested.

MIGRATION-GUIDE.md Outdated Show resolved Hide resolved
MIGRATION-GUIDE.md Outdated Show resolved Hide resolved
Copy link

@EmilianoSanchez EmilianoSanchez merged commit b9ecaaa into development Nov 11, 2024
8 checks passed
@EmilianoSanchez EmilianoSanchez deleted the type_declarations_update branch November 11, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants