Reset votes to restore to start of round when a new backup is written #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdnk
force-pushed
the
reset_stop_vote
branch
from
e0c12a0 to
3c8357b
Compare
nickdnk
changed the title
|
I think the usage of timers may be over-engineering the practice of the .stop command. Most TOs also have a rule that states restores are not allowed if damage has been taken on either side, so restoring to a point in time when the initial command was given wouldn't make much sense. Worst case scenario, users can list the backups and get an admin to restore at that point in time if needed. Otherwise, resetting the vote at each round does make sense, but maybe we should have a message output to the team that their vote was reset at the round start, if they had called stop prior to? |
|
I agree with both. I will add a “stop command vote reset” message if any team has a cast vote when it is reset. |
nickdnk
force-pushed
the
reset_stop_vote
branch
from
3c8357b to
f942162
Compare
Add message about resetting Rename TeamWantsToReloadLastRoundInfoMessage to TeamWantsToReloadCurrentRound
nickdnk
force-pushed
the
reset_stop_vote
branch
from
f942162 to
cb5d883
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thoughts? Ideally we would store the round number the initial command was given during and reset it on a timer instead.