Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that g_MatchID is reset #849

Merged
merged 1 commit into from
Aug 19, 2022
Merged

Ensure that g_MatchID is reset #849

merged 1 commit into from
Aug 19, 2022

Conversation

nickdnk
Copy link
Collaborator

@nickdnk nickdnk commented Aug 19, 2022

If you end the series or if a match configuration fails to load, you will be stuck with an invalid g_MatchId variable. This causes the backup system to incorrectly look for only backups belonging to that match, where it should be listing all backups.

@nickdnk nickdnk added the bug label Aug 19, 2022
@nickdnk nickdnk added this to the 0.10 milestone Aug 19, 2022
@nickdnk
Copy link
Collaborator Author

nickdnk commented Aug 19, 2022

@PhlexPlexico Fairly sure we can just merge this immediately, I just wanted a second opinion here.

Copy link
Collaborator

@PhlexPlexico PhlexPlexico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! I agree!

@nickdnk nickdnk merged commit 92dab66 into development Aug 19, 2022
@nickdnk nickdnk deleted the fix_gmatchid_reset branch August 20, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants