Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added surrender system #831

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Added surrender system #831

merged 1 commit into from
Sep 7, 2022

Conversation

nickdnk
Copy link
Collaborator

@nickdnk nickdnk commented Aug 13, 2022

This allows you to call !surrender or !gg when applicable to surrender the map. It uses the built-in logic for actually ending the map.

Planned for 0.11.

@nickdnk nickdnk added this to the 0.11 milestone Aug 13, 2022
@nickdnk nickdnk self-assigned this Aug 13, 2022
@nickdnk nickdnk marked this pull request as draft August 13, 2022 21:14
@nickdnk nickdnk force-pushed the add_surrender branch 7 times, most recently from 05ea638 to 88ebfdb Compare August 15, 2022 16:25
@nickdnk
Copy link
Collaborator Author

nickdnk commented Aug 15, 2022

Now fixes #549

@nickdnk nickdnk linked an issue Aug 15, 2022 that may be closed by this pull request
@nickdnk nickdnk force-pushed the add_surrender branch 3 times, most recently from e23dc3c to 63b5f42 Compare August 16, 2022 12:26
@nickdnk nickdnk force-pushed the add_surrender branch 7 times, most recently from 483f7fc to e1af0e4 Compare August 26, 2022 18:54
@nickdnk nickdnk force-pushed the add_surrender branch 4 times, most recently from 2dd77b5 to 39c8d99 Compare August 29, 2022 02:32
@nickdnk nickdnk force-pushed the add_surrender branch 11 times, most recently from d55616a to ea92160 Compare September 5, 2022 19:48
@nickdnk
Copy link
Collaborator Author

nickdnk commented Sep 5, 2022

This is now a breaking change because it removes the get5_end_match_on_empty_server cvar, as it makes no sense when this system exists.

@nickdnk nickdnk force-pushed the add_surrender branch 3 times, most recently from eb8de6a to b9241d9 Compare September 7, 2022 14:15
Add leave-surrender logic and fix unintended match end on empty server
Add message informing players to stay to win
Don't count coaches as players on team
Add min values to cvars
Use IsPlayer for connect/disconnect events
Remove get5_end_match_on_empty_server as it makes no sense when surrender is implemented
FormatEx
@nickdnk nickdnk marked this pull request as ready for review September 7, 2022 15:18
@nickdnk nickdnk merged commit 9ca36db into development Sep 7, 2022
@nickdnk nickdnk deleted the add_surrender branch September 7, 2022 15:24
nickdnk added a commit that referenced this pull request Sep 10, 2022
Add leave-surrender logic and fix unintended match end on empty server
Use IsPlayer for connect/disconnect events
Remove get5_end_match_on_empty_server as it makes no sense when surrender is implemented
FormatEx
nickdnk added a commit that referenced this pull request Sep 15, 2022
Add leave-surrender logic and fix unintended match end on empty server
Use IsPlayer for connect/disconnect events
Remove get5_end_match_on_empty_server as it makes no sense when surrender is implemented
FormatEx
nickdnk added a commit to nickdnk/get5 that referenced this pull request Sep 16, 2022
Add leave-surrender logic and fix unintended match end on empty server
Use IsPlayer for connect/disconnect events
Remove get5_end_match_on_empty_server as it makes no sense when surrender is implemented
FormatEx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player disconnect prior to ready up causes a series end
1 participant