Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder parameters of get5_creatematch to match get5_scrim #806

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

nickdnk
Copy link
Collaborator

@nickdnk nickdnk commented Jul 31, 2022

Because an empty match is default, and required if using the MySQL extension, the parameter order of get5_creatematch should match that of get5_scrim to put matchid last.

@nickdnk nickdnk added this to the 0.10 milestone Jul 31, 2022
@nickdnk nickdnk force-pushed the reorder_get5_creatematch_parameters branch from bc75ed0 to 1e0c405 Compare August 1, 2022 14:49
@nickdnk
Copy link
Collaborator Author

nickdnk commented Aug 1, 2022

Accidentally committed these changes to develop with the documentation update for it. So it's merged. Changes here: 9e9ffb3c

@nickdnk nickdnk merged commit 2e2befa into development Aug 1, 2022
@nickdnk nickdnk deleted the reorder_get5_creatematch_parameters branch August 1, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant