Include timeouts for tech pauses. #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickdnk
reviewed
May 10, 2022
|
So there was a small change I had to make here. Instead of users getting an absolute amount of time based on pauses and time left, we now just have a countdown for grace period per team, and increase the pauses each time a team calls a technical timeout. I believe this should be more inline with ESEAs tech pause system where users are granted a total of 2 tech pauses (max 5 mins grace period), and the timer does not carry over into other pauses. I've also included one more message in here whenever a team pauses and pauses get increased. Also fixed the grammatical issue there, thanks for pointing that out :) |
nickdnk
reviewed
May 10, 2022
Adjust unpausing based on commands? Compiles with no errors, time to test. Include max tech pauses. Include debug. Update pausing to set/get props to tell who is pausing. Keep track of who tech paused. Limit when tech pauses can be called while in tech pause. Disable counter if the team calling calls unpause. Remove pause/unpause util changes. Update some bad assumptions for pausing. Bad command syntax. Keep track of time so we don't spin off two timers for one pause. Feature should be complete. Minor testing still needs to be done. Include ready for unpause in tech pauses as we always want both teams to unpause. Missed call for increasing max pauses. Include edge case where users have tech pause limits but no timer. Remove call in unpause. Missed period. Remove unnecessary log message. Add 10 second expiration message. Add in check to make sure max pauses is above zero as well. Add in minute warning and then a 30 second warning. Per conversations with league organizers, tech pauses have been reworked.
PhlexPlexico
force-pushed
the
techpause-changes
branch
from
81dd5c8 to
8034669
Compare
Fix dangling timers for when teams unpause before a timer finishes.
PhlexPlexico
force-pushed
the
techpause-changes
branch
from
1e0b86a to
8a5703a
Compare
|
Looks good to me. The default unlimited tech pauses was always a precarious situation :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following two new config options and features:
get5_tech_pause_time "0"- If set to a positive non-zero value, this will give a time limit for tech pauses before any team can unpause. Includes a new message when 30 seconds remain on a tech pause, and when the grace period expires.get5_max_tech_pauses "0"- If set to a positive non-zero value, this will also limit the amount of tech pauses a team may have during freeze time.These features were requested in the Discord as there were some TOs mentioning that users were abusing the tech pauses, and the way ESEA handles it is with using timers for when users can unpause, and limits on how many tech pauses are allowed. One stop-gap to prevent teams abusing the timer is that once the team who has called the tech pause chooses to resume, their respective timers will stop as well. Up until the grace period expires, both teams must agree to resume the match. The max tech pauses do not increase until the grace period for that specific pause has run out.
Debug statements have been added as well to include them in team variables, such as the time remaining in a tech pause, how many tech pauses a team has used, and which team has called a tech pause.
Included with this is three new phrases that should be translated to other languages, but I believe it's not required as there are some translations already missing.
There is also a bug fix included that allowed users to unpause tech calls without the acceptance of the other team, once one tech pause had been called. I'm not sure if this was initially intended as a means of avoiding people abusing tech pause/unpause, but I believe this feature may be the next best thing.
I've tested this to the best of my ability, but I'm certainly not in QA so there may be some extreme edge cases that I have missed.