Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match restore issues #652

Merged
merged 3 commits into from
Apr 10, 2022
Merged

Match restore issues #652

merged 3 commits into from
Apr 10, 2022

Conversation

arildboifot
Copy link
Contributor

While testing the restore functionality I ran into 3 separate issues:

  1. Restoring to another map than the current map results in the match starting Warmup or Knife depending on the current map number.
  2. Restoring to second half on an another map than the current map results in the "end of first half screen" and incorrect match scores. Also the teams may be spawned on incorrect sides.
  3. mp_match_restart_delay was not set

Any feedback is much appreciated!

@arildboifot
Copy link
Contributor Author

arildboifot commented Mar 23, 2021

There's still a issue that results in an unpaused match when restoring on a clean server for the first time. When restoring a second time everything is good. I'll try to dig into that tomorrow.

EDIT: This only happens when clients are connected and on the "select sides screen" before running the restore.

@nickdnk
Copy link
Collaborator

nickdnk commented Jan 4, 2022

@arildboifot Do you have any updates here? Seems like you are onto something here. Come on the Discord if you want. Link in readme.

@rpkaul
Copy link

rpkaul commented Mar 30, 2022

@arildboifot you have any update on this brother ?

@arildboifot
Copy link
Contributor Author

arildboifot commented Mar 31, 2022

Thanks for reminder! We've been running with this modification since this PR and done a quite a few backups/restores without hitting the edge case described above. I haven't had time to look more into the edge case unfortunately.

@nickdnk
Copy link
Collaborator

nickdnk commented Apr 1, 2022

@splewis Since @arildboifot says it works, could you take a look and merge it if you don't see any issues? I'm not very familiar with backups in Get5, as I don't use them at all, so I'd rather not merge this alone.

@splewis
Copy link
Owner

splewis commented Apr 7, 2022

I'll take a look at this during this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants