-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match restore issues #652
Match restore issues #652
Conversation
There's still a issue that results in an unpaused match when restoring on a clean server for the first time. When restoring a second time everything is good. I'll try to dig into that tomorrow. EDIT: This only happens when clients are connected and on the "select sides screen" before running the restore. |
@arildboifot Do you have any updates here? Seems like you are onto something here. Come on the Discord if you want. Link in readme. |
@arildboifot you have any update on this brother ? |
Thanks for reminder! We've been running with this modification since this PR and done a quite a few backups/restores without hitting the edge case described above. I haven't had time to look more into the edge case unfortunately. |
@splewis Since @arildboifot says it works, could you take a look and merge it if you don't see any issues? I'm not very familiar with backups in Get5, as I don't use them at all, so I'd rather not merge this alone. |
I'll take a look at this during this weekend. |
While testing the restore functionality I ran into 3 separate issues:
Any feedback is much appreciated!