Initial value for g_LogoBasePath #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found error in logs about not able to check for logo path, I think it's due to g_LogoBasePath not having any value initally. Not sure if this is correct approach. The error itself ``` L 06/01/2020 - 15:30:31: [SM] Exception reported: Invalid path. An empty path string is not valid, use "." to refer to the current working directory. L 06/01/2020 - 15:30:31: [SM] Blaming: get5_apistats.smx L 06/01/2020 - 15:30:31: [SM] Call stack trace: L 06/01/2020 - 15:30:31: [SM] [0] DirExists L 06/01/2020 - 15:30:31: [SM] [1] Line 160, ./scripting/get5_apistats.sp::Get5_OnSeriesInit L 06/01/2020 - 15:30:31: [SM] [3] Call_Finish ... ```
|
Makes sense, it was an obvious bug (my bad) which should get patched. |
|
The code probably probably shouldn't be using a global variable, but this is fine - thanks for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found error in logs about not able to check for logo path, I think it's due to g_LogoBasePath not having any value initally. Not sure if this is correct approach.
The error itself
@MoritzLoewenstein Can you validate my PR?