Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pins in components not being rendered #886

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Fix pins in components not being rendered #886

merged 1 commit into from
Oct 17, 2023

Conversation

jrray
Copy link
Collaborator

@jrray jrray commented Oct 9, 2023

Packages that try to use fromBuildEnv in a component were not getting the appropriate version pinned at build time, as in:

pkg: my-pkg/1.0.0

build:
  options:
    - pkg: test

install:
  components:
    - name: run
      files: ['*']
      requirements:
        - pkg: test
          fromBuildEnv: Binary

Packages that try to use `fromBuildEnv` in a component were not getting
the appropriate version pinned at build time, as in:

```yaml
pkg: my-pkg/1.0.0

build:
  options:
    - pkg: test

install:
  components:
    - name: run
      files: ['*']
      requirements:
        - pkg: test
          fromBuildEnv: Binary
```

Signed-off-by: J Robert Ray <[email protected]>
@jrray jrray added the bug Something isn't working label Oct 9, 2023
@jrray jrray self-assigned this Oct 9, 2023
@jrray jrray requested a review from rydrman October 9, 2023 18:05
@jrray jrray merged commit bc824b3 into main Oct 17, 2023
@jrray jrray deleted the component-pins branch October 17, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants