Refactor rendering logic into separate methods #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rydrman do you have a use case for hard linking into external directories? |
|
Yes, we leverage this quite extensively. Our storage is read-only for users and the permissions are standardized so we hardlink nearly all of our large deployments |
|
Okay I guess I need to rethink my refactoring. However don't you agree that this is a dangerous feature to support, in general? I think it might be good to gate it behind some kind of opt-in setting or something, so people understand the consequences. |
jrray
force-pushed
the
no-hard-links-for-dir-renders
branch
from
1ad0078 to
7ec8e8b
Compare
jrray
changed the title
jrray
force-pushed
the
open-repo-type-state
branch
from
086c6b9 to
d08ddba
Compare
This change was prompted by wanting to refactor the code to work towards having different trait bounds for the functions that need a repository that supports renders (e.g., rendering into a repository) versus functions that render into a plain directory. Rework `RenderType` so the method that renders into a hardlink doesn't need to worry about getting a `RenderType::Copy` value. Signed-off-by: J Robert Ray <[email protected]>
jrray
force-pushed
the
no-hard-links-for-dir-renders
branch
from
7ec8e8b to
51a8e45
Compare
|
A warning or extra confirmation on the command line maybe since that's really the only place you can invoke it like that... |
rydrman
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was prompted by wanting to refactor the code to work towards
having different trait bounds for the functions that need a repository
that supports renders (e.g., rendering into a repository) versus
functions that render into a plain directory.
Rework
RenderTypeso the method that renders into a hardlink doesn'tneed to worry about getting a
RenderType::Copyvalue.