-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NaN's produced. #8
Comments
Hi, I have fixed it, please download version 0.2.2 and see if it solves the issue. Cheers, |
Thank you. For this example, it of course solves the issue. We will try with other datasets also and let you know if we come across issues. Thank you again for fixing this so soon. |
Sorry, I spoke too soon. The problem still exists. Please try: and the underflow has not gone away. How do I get out of these NaNs? |
Ohh, I see. I increased the new scaling factor. Please let me know if you have further issues. I might have to search for a more elaborated fix... |
So, of course, it works for this particular dataset but I get around 18.5% voxels activated inside the mask when I use 2-sided thresholding, which is hard to believe. Can you please see if there is a more correct fix? Btw, here is the wrapper function I used.
For the file as above:
For a different file (attached): I get 24.6%, which is simply not possible.
I guess that I will wait for your elaborate fix. |
Are you sure these are Z-score images? Red is the standard normal, blue is your data. Your distribution is clearly much different from the null, you can expect a lot of "unlikely" clusters of activations to emerge. |
The images are of voxel-wise standardized values under the null. The normal density in your figure is likely based on the assumption of independence of voxels (I am guessing). I am not completely sure that these are comparable. But it is also possible that these have thicker tails under the null and are better modeled by the t with smaller degrees of freedom. I guess that your assumptions of normality under the null are very rigid. |
Yep, the plot is with independence assumed. But note that positive dependence (which we expect) will make the tails lighter (that's what we take advantage of when doing Gaussian Random Field (GRF) theory-based FWER, BTW). It's not clear how you standardised the values, but if they are T-values, definitely "Gaussianize" them with the proper dof, in order to be valid for pTFCE or any other GRF-based method. Yes, assumptions are kind of rigid for all GRF-based methods (i.e. for the majority of parametric thresholding methods in neuroimaging). |
The strange distribution might also explain why the underflow (and thus, the NaN-issue) did not happen before. |
This bug is not quite resolved. Here is an example.
We get around 5000+ NaNs. Thanks! |
Thanks, I'll have a look as soon a possible. |
Bstand2-int-death-negative.nii.gz
mask.nii.gz
The files above, which are of Zmaps produce NaNs for 307 voxels. Here is what I do:
I get:
And:
What is wrong? How do I get out of these NaNs?
The text was updated successfully, but these errors were encountered: