Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use foldhash in dict encoding #980

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Use foldhash in dict encoding #980

merged 1 commit into from
Oct 4, 2024

Conversation

AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Oct 4, 2024

This PR has two benefits:

  1. Nice performance gains (on my laptop)
    Screenshot 2024-10-04 at 22 38 42
  2. The hashbrown folks seem to be on top of the hashing game, and this PR pulls the hasher directly from it.

@lwwmanning lwwmanning merged commit ee0ff2a into develop Oct 4, 2024
4 checks passed
@lwwmanning lwwmanning deleted the adamg/dict-foldhash branch October 4, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants