Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BitWidthFreq must be u64/usize #974

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

danking
Copy link
Member

@danking danking commented Oct 3, 2024

We assume elsewhere that this statistic is a u64 (usize is auto-converted to u64 when we convert to Scalar). I am not entirely sure how I triggered this, but it happens on PR #969.

We assume elsewhere that this statistic is a u64 (usize is
auto-converted to u64 when we convert to Scalar). I am not
entirely sure how I triggered this, but it happens on PR
#969.
@danking danking requested a review from a10y October 3, 2024 20:31
@danking danking marked this pull request as ready for review October 3, 2024 20:31
@danking danking enabled auto-merge (squash) October 3, 2024 20:31
@danking danking merged commit 1f21e30 into develop Oct 3, 2024
4 checks passed
@danking danking deleted the dk/fix-bit-width-freq-stat-for-nulls branch October 3, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants