feat: SparseArray uses ScalarValue instead of Scalar #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danking
force-pushed
the
dk/cleanup-metadata--sparse-array-uses-scalarvalue
branch
from
14215be
to
bc67a80
Compare
robert3005
reviewed
Oct 1, 2024
| Some(idx) => scalar_at_unchecked(&self.values(), idx).cast(self.dtype()), | ||
| } | ||
| Ok(match self.search_index(index)?.to_found() { | ||
| None => self.fill_owned_scalar(), |
There was a problem hiding this comment.
I think fill_scalar is a better name for this?
robert3005
reviewed
Oct 1, 2024
| ) -> VortexResult<Self> { | ||
| if !matches!(indices.dtype(), &DType::IDX) { | ||
| vortex_bail!("Cannot use {} as indices", indices.dtype()); | ||
| } | ||
| if values.dtype() != fill_value.dtype() { |
There was a problem hiding this comment.
I think it would be nice to keep a check like this but would have to add method to dtype to check if it is a valid scalar value for the type
There was a problem hiding this comment.
robert3005
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.