Compressor recursion #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gatesn
commented
Mar 6, 2024
gatesn
commented
- Compressors now return results.
- All arrays are compressed using sampled compression. This means we take one sample from the very top-level array. This might not be quite right, and we may want chunked arrays to push-down sampling? We would need to add an ArrayCompression trait if we want arrays to be able to override this behaviour.
- The bench is ignored for now since we now require as_contiguous to be implemented for many more array types. This will be FLUP.
robert3005
reviewed
Mar 6, 2024
robert3005
approved these changes
Mar 6, 2024
vortex-array/src/compress.rs
Outdated
| } | ||
| }, | ||
| ); | ||
| let (_, compressed_sample) = sampling_result?; | ||
|
|
||
| return compressed_sample |
There was a problem hiding this comment.
you could put ok around the whole expression not inside it?
vortex-array/src/compress.rs
Outdated
| debug!( | ||
| "Compressed array with dtype: {} and encoding: {} using: {}", | ||
| "Compressed sample with dtype: {} and encoding: {}, using: {}", |
There was a problem hiding this comment.
at this point you're compressing the array and not the sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.