Fix slicing of ChunkedArray if end index == array length #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
approved these changes
Aug 20, 2024
a10y
reviewed
Aug 20, 2024
Comment on lines
+100
to
+103
| SearchResult::Found(i) => { | ||
| if i == self.nchunks() { | ||
| i - 1 | ||
| } else { |
There was a problem hiding this comment.
feels like there are a lot of bugs of this flavor
There was a problem hiding this comment.
Yes, I thought this was wrong in couple of places but it was hidden by multiple other bugs. Need to add a new api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.