Support Temporal scalar conversion between datafusion and arrow #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
reviewed
Aug 20, 2024
a10y
reviewed
Aug 20, 2024
Co-authored-by: Andrew Duffy <[email protected]>
a10y
reviewed
Aug 20, 2024
| macro_rules! as_primitive { | ||
| ($T:ty, $PT:tt) => { | ||
| paste! { | ||
| pub fn [<as_ $T>](self) -> Option<$T> { |
There was a problem hiding this comment.
Suggested change
| pub fn [<as_ $T>](self) -> Option<$T> { | |
| #[doc = "Access PValue as `" $T "`, returning `None` if conversion is unsuccessful"] | |
| pub fn [<as_ $T>](self) -> Option<$T> { |
There was a problem hiding this comment.
Ooo, I wasn't sure how to do this. Will make a pr
There was a problem hiding this comment.
Made #658 since this pr merged
a10y
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.