Fix vortex compressed benchmarks #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert3005
commented
Aug 9, 2024
AdamGS
approved these changes
Aug 9, 2024
a10y
reviewed
Aug 9, 2024
| } | ||
|
|
||
| impl VortexTableOptions { | ||
| pub fn new(schema: SchemaRef, data_files: Vec<VortexFile>) -> Self { | ||
| pub fn new(schema: SchemaRef, data_files: Vec<VortexFile>, ctx: Arc<Context>) -> Self { |
There was a problem hiding this comment.
99% of the time (100% of the time right now) you're gonna just be using the default codecs.
maybe it'd make more sense to have an extra_encodings config rather than requiring clients to build a whole context just to pass defaults
There was a problem hiding this comment.
I think I agree with you. I am not happy with the flow here. I think there's probably just a default that has to have erverything for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.