Avoid dtype comparison failure in take -- upcast indices in take_strict_sorted
#464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a10y
reviewed
Jul 16, 2024
| &Scalar::from(chunk_begin).cast(chunk_indices.dtype())?, | ||
| )? | ||
| } else { | ||
| // TODO: this is unnecessary, could instead upcast in the subtract. |
There was a problem hiding this comment.
i think it's better to assert on it here, b/c you can do subtract_scalar with negative value. let's remove the TODO?
There was a problem hiding this comment.
will update comment
a10y
reviewed
Jul 16, 2024
Comment on lines
+107
to
+109
| PType::F16 => panic!("Unsupported ptype f16"), | ||
| PType::F32 => panic!("Unsupported ptype f32"), | ||
| PType::F64 => panic!("Unsupported ptype f64"), |
There was a problem hiding this comment.
to remove any string concat at compile time
There was a problem hiding this comment.
(So max_value can be a const fn since format! isn't const)
a10y
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upcast the indices in
take_strict_sortedbut first trying to upcast the scalar value, then the indices themselves.Note. this is likely to be superseded by
array.filter(bool) -> array.