Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FoR array holds encoded values as unsinged #401

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Conversation

robert3005
Copy link
Member

@robert3005 robert3005 commented Jun 21, 2024

fixes #400. With this change the underlying encoded array is always sorted after for encoding

vortex-scalar/src/primitive.rs Outdated Show resolved Hide resolved
encodings/fastlanes/src/for/compress.rs Outdated Show resolved Hide resolved
@robert3005 robert3005 disabled auto-merge June 24, 2024 15:41
@robert3005 robert3005 enabled auto-merge (squash) June 24, 2024 15:51
@robert3005 robert3005 merged commit 3dbcdc5 into develop Jun 24, 2024
2 checks passed
@robert3005 robert3005 deleted the rk/forunsigned branch June 24, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FOR encoding a sorted array doesn't preserve sortedness
2 participants