Refactor for DType::Primitive #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwwmanning
reviewed
Apr 30, 2024
| pub fn is_unsigned_int(&self) -> bool { | ||
| PType::try_from(self) | ||
| .map(|ptype| ptype.is_unsigned_int()) | ||
| .unwrap_or_default() |
There was a problem hiding this comment.
nit: personally I dislike unwrap_or_default, since it requires the reader to think/know the default of the type. For types that a trivial to instantiate, the explicit version is generally clearer -> i.e., unwrap_or(false)
There was a problem hiding this comment.
I think clippy yells at you for that. Maybe we can configure it to be opposite for primitives?
There was a problem hiding this comment.
You're not the only one: rust-lang/rust-clippy#11630
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154