Composite Arrays #122
Merged
Composite Arrays #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatesn
commented
Mar 19, 2024
| @@ -14,7 +14,11 @@ impl EncodingCompression for CompositeEncoding { | |||
| array: &dyn Array, | |||
| _config: &CompressConfig, | |||
| ) -> Option<&dyn EncodingCompression> { | |||
| (array.encoding().id() == &Self::ID).then_some(self) | |||
There was a problem hiding this comment.
Hmm, maybe we could flatten in this compressor instead of doing it in compress.rs
| @@ -53,6 +61,7 @@ impl FlattenFn for CompositeArray { | |||
|
|
|||
| impl ScalarAtFn for CompositeArray { | |||
| fn scalar_at(&self, index: usize) -> VortexResult<Scalar> { | |||
| // TODO(ngates): this seems wrong... | |||
There was a problem hiding this comment.
So I think scalars make it obvious that every dtype should have a canonical physical representation. Albeit where some dtype parameters are pluggable, e.g. int width?
robert3005
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploring an idea around composite arrays. Essentially this,
impl ArrayCompute for TypedCompositeArray<LocalDateTimeMetadata>