Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Even more docs #1105

Merged
merged 12 commits into from
Oct 21, 2024
Merged

Even more docs #1105

merged 12 commits into from
Oct 21, 2024

Conversation

AdamGS
Copy link
Contributor

@AdamGS AdamGS commented Oct 21, 2024

Including @a10y's comments on the previous PR.

Moved some things around to reduce the noise in the main rustdoc page, which I believe improves overall readability. I [re]moved a few modules in a way I believe maintains the relevant API surface, which we should probably keep hammering at to the absolute useful minimum before we release a stable version.

@AdamGS AdamGS marked this pull request as ready for review October 21, 2024 18:18
@AdamGS AdamGS changed the title [WIP] Even more docs Even more docs Oct 21, 2024
@@ -264,7 +266,7 @@ pub trait ToArrayData {
fn to_array_data(&self) -> ArrayData;
}

/// Collects together the behaviour of an array.
/// Collects together the behavior of an array.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇺🇸

Copy link
Member

@danking danking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lwwmanning lwwmanning enabled auto-merge (squash) October 21, 2024 18:29
@lwwmanning lwwmanning merged commit 015b067 into develop Oct 21, 2024
5 checks passed
@lwwmanning lwwmanning deleted the adamg/more-docs-2-2024-1021 branch October 21, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants